Backmerge: #3914 – Add support for opening structures in CDX format embedded into MS PowerPoint #3941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MS PowerPoint add and integrate new components
captain2b
force-pushed
the
3914-add-support-for-opening-structures-in-cdx-format-embedded-into-ms-powerpoint
branch
from
b1f2737
to
0a5458b
Compare
captain2b
changed the title
captain2b
changed the title
…MS PowerPoint fix concurrent generateImageAsBase64 requests, add tests
captain2b
force-pushed
the
3914-add-support-for-opening-structures-in-cdx-format-embedded-into-ms-powerpoint
branch
from
b9e869b
to
643a4c9
Compare
auto-assign
bot
requested review from
AlexeyGirin,
rrodionov91 and
StarlaStarla
captain2b
commented
Jan 24, 2024
| @@ -66,12 +67,14 @@ function handle( | |||
| type: messageType, | |||
| payload, | |||
| hasError: false, | |||
| inputData, | |||
There was a problem hiding this comment.
needed to add new parameter to allow concurrent requests
captain2b
commented
Jan 24, 2024
| resolve(msg.payload); | ||
| } else { | ||
| reject(msg.error); | ||
| if (msg.inputData === inputData) { |
There was a problem hiding this comment.
to filter the responses in case of a multiple listeners
…MS PowerPoint fix decoding for large arrays
StarlaStarla
approved these changes
Jan 25, 2024
captain2b
changed the title
rrodionov91
approved these changes
Jan 26, 2024
captain2b
deleted the
3914-add-support-for-opening-structures-in-cdx-format-embedded-into-ms-powerpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
This PR adds new functionality that allows user to see structures from pptx
Example of presentation with structures:
original.pptx
Check list
#1234 – issue name